miraclx/freyr-js

High memory usage

Open

#646 opened on Jan 23, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,279 stars) (154 forks)user submission
bughelp wanted

Description

Thank you for developing this app. I appreciate its user-friendliness.

However, I noticed that when downloading multiple large playlists and albums using queue, the app's memory usage spikes significantly. I wanted to point this out so that you can consider optimizing the memory management for these scenarios.

2024-01-23_16-29

Command used: npx freyr get https://open.spotify.com/artist/4CyxMgnF71FyOWADVWxJRE?si=ryq2taQMQtmXns5eyoJtoA https://open.spotify.com/artist/1v7B6ZWa7QRQS3knn3Jvf4 https://open.spotify.com/playlist/37i9dQZF1DWXgtgITTKvYl https://open.spotify.com/playlist/37i9dQZF1DX5wgKYQVRARv

Contributor guide

Tech stack
javascriptnodejs
Domain
cli
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Node.js memory profilingCLI tool debugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate memory usage spikes during concurrent downloads. Use Node.js heap snapshot tools (e.g., inspect) to identify objects retaining memory. Look at the download queue implementation in the source code (likely in src/ directory). Check for any unstreamed responses or caches growing unboundedly.