miraclx/freyr-js

Weird case when downloading a playlist with track that exists in another directory

Open

#351 opened on Sep 18, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,279 stars) (154 forks)user submission
enhancementgood first issuehelp wanted

Description

As mentioned in https://github.com/miraclx/freyr-js/pull/350#issuecomment-1250316825

An unintended side effect here is with playlist generation, if a file exists in a check dir, but not the output directory and downloading was skipped, it doesn't get included in the playlist.

Opening this issue for visibility.

Contributor guide

Tech stack
javascriptnodejs
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptNode.jsunderstanding of playlist logic
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Look at the referenced comment in PR #350 for context. Investigate the playlist generation logic in the codebase, particularly how track existence checks are performed across directories. Identify where the check directory vs output directory logic resides and ensure skipped tracks are included if they exist in the output directory or the check directory.