miraclx/freyr-js

Playlist download operation does not gracefully crash when certain songs present

Open

#169 opened on Mar 22, 2022

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (2,279 stars) (154 forks)user submission
action or closebuggood first issuequestion

Description

An Apple Music playlist (~99 songs) I was trying to download kept crashing with the following error:

[•] Collating...
  [•] Inquiring tracks...(failed: [Cannot read properties of undefined (reading '0')]) 
 [i] An error occurred while processing the query (Failed to collect playlist tracks)

After a lot of trial and error, I narrowed the problem down to a single track: "Watch - Nosaj Thing": https://music.apple.com/us/album/watch/1608121372?i=1608121589

Removing this single track from the playlist allowed the entire playlist to download successfully.

Contributor guide

Tech stack
javascriptnodejsrest api
Domain
backendtoolingapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic JavaScriptError handlingApple Music API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the track parsing logic in the Apple Music module. Look for where response data is accessed with index [0] without checking for undefined. The crash occurs on a specific track (Watch Nosaj Thing). Check if the track has missing or malformed data. Examine the code around the 'Inquiring tracks' step, likely in src/providers/apple music.js. Consider adding input validation and graceful error handling for such cases.