miraclx/freyr-js

pkg-packaged execuable cannot run youtube-dl

Open

#158 opened on Mar 10, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (2,279 stars) (154 forks)user submission
enhancementhelp wanted

Description

Log from a pkg executable on Linux:

       | ➤ Collating sources...
       |  ➤ [•] YouTube Music...[success, found 5 sources]
       | ➤ Awaiting audiofeeds...(failed: [Command failed with ENOENT: /snapshot/freyr-js/node_modules/youtube-dl-exec/bin/youtube-dl --socket-timeout 20 --no-cache-dir --dump-single-json -- L0yOCIqqBWM
spawn /snapshot/freyr-js/node_modules/youtube-dl-exec/bin/youtube-dl ENOENT])

When packaging with pkg I get these warnings:

  The file must be distributed with executable as %2.
  %1: node_modules/open/xdg-open
  %2: path-to-executable/xdg-open
> Warning Cannot include file %1 into executable.
  The file must be distributed with executable as %2.
  %1: node_modules/open/xdg-open
  %2: path-to-executable/xdg-open
> Warning Failed to make bytecode node16-x64 for file /snapshot/freyr-js/node_modules/string-width/index.js
> Warning Failed to make bytecode node16-x64 for file /snapshot/freyr-js/node_modules/strip-ansi/index.js
> Warning Failed to make bytecode node16-x64 for file /snapshot/freyr-js/node_modules/strip-ansi/node_modules/ansi-regex/index.js
> Warning Failed to make bytecode node16-x64 for file /snapshot/freyr-js/node_modules/string-width/index.js
> Warning Failed to make bytecode node16-x64 for file /snapshot/freyr-js/node_modules/strip-ansi/index.js
> Warning Failed to make bytecode node16-x64 for file /snapshot/freyr-js/node_modules/strip-ansi/node_modules/ansi-regex/index.js
> Warning Failed to make bytecode node16-x64 for file C:\snapshot\freyr-js\node_modules\string-width\index.js
> Warning Failed to make bytecode node16-x64 for file C:\snapshot\freyr-js\node_modules\strip-ansi\index.js
> Warning Failed to make bytecode node16-x64 for file C:\snapshot\freyr-js\node_modules\strip-ansi\node_modules\ansi-regex\index.js

Seems to be an issue with pkg because it's also using Windows paths on linux.

Contributor guide

Tech stack
javascriptnodejs
Domain
clibuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
pkgNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the pkg configuration in package.json or build script to ensure the youtube dl binary from youtube dl exec is included in the snapshot. The error shows that the binary is at /snapshot/.../bin/youtube dl but fails with ENOENT, likely because pkg does not include native binaries by default. Consider using pkg's 'assets' option or a post install script to copy the binary. Also examine the warnings about xdg open which suggest additional file exclusions. Look at the existing build configuration and any previous discussions in comments for hints.