miraclx/freyr-js

pkg-packaged execuable cannot run youtube-dl

Open

#158 opened on Mar 10, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (154 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (2,279 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Log from a pkg executable on Linux:

       | ➤ Collating sources...
       |  ➤ [•] YouTube Music...[success, found 5 sources]
       | ➤ Awaiting audiofeeds...(failed: [Command failed with ENOENT: /snapshot/freyr-js/node_modules/youtube-dl-exec/bin/youtube-dl --socket-timeout 20 --no-cache-dir --dump-single-json -- L0yOCIqqBWM
spawn /snapshot/freyr-js/node_modules/youtube-dl-exec/bin/youtube-dl ENOENT])

When packaging with pkg I get these warnings:

  The file must be distributed with executable as %2.
  %1: node_modules/open/xdg-open
  %2: path-to-executable/xdg-open
> Warning Cannot include file %1 into executable.
  The file must be distributed with executable as %2.
  %1: node_modules/open/xdg-open
  %2: path-to-executable/xdg-open
> Warning Failed to make bytecode node16-x64 for file /snapshot/freyr-js/node_modules/string-width/index.js
> Warning Failed to make bytecode node16-x64 for file /snapshot/freyr-js/node_modules/strip-ansi/index.js
> Warning Failed to make bytecode node16-x64 for file /snapshot/freyr-js/node_modules/strip-ansi/node_modules/ansi-regex/index.js
> Warning Failed to make bytecode node16-x64 for file /snapshot/freyr-js/node_modules/string-width/index.js
> Warning Failed to make bytecode node16-x64 for file /snapshot/freyr-js/node_modules/strip-ansi/index.js
> Warning Failed to make bytecode node16-x64 for file /snapshot/freyr-js/node_modules/strip-ansi/node_modules/ansi-regex/index.js
> Warning Failed to make bytecode node16-x64 for file C:\snapshot\freyr-js\node_modules\string-width\index.js
> Warning Failed to make bytecode node16-x64 for file C:\snapshot\freyr-js\node_modules\strip-ansi\index.js
> Warning Failed to make bytecode node16-x64 for file C:\snapshot\freyr-js\node_modules\strip-ansi\node_modules\ansi-regex\index.js

Seems to be an issue with pkg because it's also using Windows paths on linux.

Contributor guide

Research direction
Investigate how to include youtube dl binary in pkg snapshot using pkg's assets configuration. Check the warning about xdg open and bytecode failures; they may be related to incorrect paths. Consider using a post install script or asset configuration to ensure youtube dl is accessible at runtime.
Tech stack
javascriptnodejs
Domain
build systemtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
Node.jsnpmpkg
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50