minj/foxtrick

Check for team names with the same beginning in ShowLineupSet

Open

#1,509 opened on May 7, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (52 forks)auto 404
MiscPriority-Lowacceptedbuggood first issuehacktoberfest

Repository metrics

Stars
 (80 stars)
PR merge metrics
 (PR metrics pending)

Description

Need to check why this is based on indexOf check. Probably to do with long team names.

From: barna- PostID: 16963779.494 To: Everyone Re: 16963779.1 Datetime: 2017-04-08 19:47 Message:

If I change my lineup, and two teams' names start the same characters, both team get bolded style.

For example, my group is here:

(11604)

Contributor guide

Research direction
Investigate the ShowLineupSet function where team names are compared using indexOf. Identify why names with same beginning cause both to be bolded and propose a fix using exact match or proper comparison.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75