minj/foxtrick

Pass SourceSystem to external sites in Links module

Open

#1,329 opened on Oct 5, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (52 forks)auto 404
ExternalLinksPriority-Lowack-neededenhancementfeaturegood first issuehacktoberfesttask

Repository metrics

Stars
 (80 stars)
PR merge metrics
 (PR metrics pending)

Description

I see HT uses

  1. &SourceSystem=Hattrick for League/Friendly matches and
  2. &SourceSystem=HTOIntegrated for tournament/single/practice matches

to differentiate between those matches. Apparently, HT is recycling MatchIDs in HTOIntegrated, and is very unlikely to revert.

Issue : external links on match-report pages are refering to old/core hattrick MatchIDs

  1. http://www.databased.at/hattrick/halloffame/?matchid=7019889
  2. http://htev.org/match/7019889/
  3. http://www.fantamondi.it/HTMS/index.php?page=matchanalyze&matchid=7019889&lang=en-GB
  4. http://www.htstats.com/matchinfo-7019889&setlang=en-GB

Are these external systems equipped to handle tournament/single/practice matches? If they do, then don't we need to update refering URLs?

Contributor guide

Research direction
Investigate the external systems (databased.at, htev.org, fantamondi.it, htstats.com) to determine if they support the SourceSystem parameter for tournament/single/practice matches. If they do, update the match report URLs in the FoxTrick Links module to include the appropriate SourceSystem parameter.
Tech stack
javascript
Domain
frontendbackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptHTML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70