mina-deploy/mina

Current path symlink

Open

#496 opened on Dec 26, 2016

View on GitHub
 (7 comments) (2 reactions) (0 assignees)Ruby (4,141 stars) (460 forks)batch import
Help wantedenhancement

Description

I've started to update our deploy script from 0.3 to 1.x and have noticed that now the current symlink use a global path. In 0.3 it was a relative.

It breaks FTP clients connection through the current folder.

Contributor guide

Tech stack
rubyshell
Domain
clidevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rubysymlink concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue describes that the current symlink uses a global path instead of a relative one, breaking FTP clients. To fix, locate the code that creates the symlink in the deploy scripts (likely in lib/mina/deploy.rb or similar). Change the symlink command to use a relative path (e.g., use `ln sfn` with a relative target). Verify the change works with existing tests and ensure it doesn't break other functionality. Consider adding a test for symlink behavior.