mimblewimble/grin

Re-introduce integration tests for the node

Open

#2957 opened on Jul 22, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (4,876 stars) (991 forks)batch import
enhancementgood first issuehelp wanted

Description

In the past the node and the wallet were in the same repo. When the wallet was extracted into a separate repo, integration tests were moved to - https://github.com/mimblewimble/grin-wallet/tree/master/integration It would be beneficial to provide a simple way to run integration suits as part of node tests too. There are several possible options (there are some other for sure):

  • Move part of the tests to grin repo. Many tests requires wallet functionality too, we could move only tests which don't require wallet, but it doesn't sound great. We could create some mock wallet, not sure if this effort is justified.
  • Extract test into another repo and add to grin and grin-wallet as submodule. The issue is how to make cargo happy in this case and how to specify grin-wallet dependency in grin and vice versa.
  • Don't touch anything and always run wallet test with local version of grin repo. It adds some time to CI build and UX is poor.

Contributor guide

Tech stack
rust
Domain
testingbackend
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Rust testing knowledgeCargo workspace understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Review the three options outlined in the issue: moving tests to the grin repo, extracting tests into a submodule, or running wallet tests with a local grin version. Evaluate which approach best balances maintainability and CI efficiency. Look at the linked grin wallet integration tests for reference.