mimblewimble/grin

Rust-yaml dependency must be updated

Open

#2175 opened on Dec 18, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Rust (4,876 stars) (991 forks)batch import
good first issuetask

Description

Currently we use 0.4.2 (used by serde) and 0.3.5 (used by clap). Cargo audit is unhappy:

$cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 17 security advisories (from /home/ubuntu/.cargo/advisory-db)
    Scanning Cargo.lock for vulnerabilities (311 crate dependencies)
error: Vulnerable crates found!

ID:      RUSTSEC-2018-0006
Crate:   yaml-rust
Version: 0.3.5
Date:    2018-09-17
URL:     https://github.com/chyh1990/yaml-rust/pull/109
Title:   Uncontrolled recursion leads to abort in deserialization
Solution: upgrade to: >= 0.4.1

error: 1 vulnerability found!

I sent a PR against clap, opening this issue to track the update https://github.com/clap-rs/clap/pull/1396

Contributor guide

Tech stack
rust
Domain
security
Issue type
security
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustCargo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue tracks a security vulnerability in yaml rust dependency. A PR has been sent to clap to update its dependency (link: https://github.com/clap rs/clap/pull/1396). To resolve this issue, the maintainer needs to update the version of yaml rust in the Cargo.toml file, ensuring compatibility with serde's version. Check the linked PR for any required changes and test the build.