mimblewimble/grin

Update mining status code to support multiple "edge_bits" value

Open

#1875 opened on Oct 29, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (4,876 stars) (991 forks)batch import
enhancementgood first issuehelp wanted

Description

Now that we support multiple cuckatoo/cuckaroo sizes having a single "gps" value displayed may be confusing.

The grin-miner tui says "Mining status: Mining at height xxx at yyy GPS

If the user is mining with 2 plugins, a CPU mining edge_bits=29, and a GPU mining edge_bits=30, that message with a single GPS means what?

I see two options (but a third better option may exist):

  1. normalize and merge all graph rates into a single GPS
  2. display each rate as a separate GPS value

Contributor guide

Tech stack
rust
Domain
cliblockchain
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Rustgrin miner codebasemining graph rates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Explore the grin miner's mining status display code, likely in the miner module. Understand how GPS is computed per plugin and how multiple plugins with different edge bits are handled. Implement either option 1 (normalize and merge all graph rates into a single GPS) or option 2 (display each rate separately). Consider the maintainer's preference if any, but both are valid. Test the changes with multiple plugins.