milankinen/livereactload

Support Web Workers

Open

#102 opened on Feb 18, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (866 stars) (61 forks)batch import
enhancementhelp wanted

Description

When I use livereactload with a React app (0.14.7) with mapbox-gl-js I get errors with Web Workers (which mapbox-gl-js uses webworkify to create). I don't really know enough about how livereactload works to debug further. It seems to be related to module detection and browserify wrapping in the web worker? Without livereactload everything works fine. I am using babelify, seeing this in both babel v5 & v6, and both using ES2015 and CommonJS module syntax.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
Basic knowledge of Web WorkersFamiliarity with Browserify and module bundling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue lacks details on specific error messages. To investigate, enable livereactload with a minimal React app using mapbox gl js and observe Web Worker errors. Check how livereactload transforms modules and whether webworkify's worker bundle is being correctly handled. Look at the source code in the livereactload repository to understand module wrapping.