mikepenz/Crossfader

Crossfader doesn't recreate state correctly after configuration change

Open

#18 opened on May 7, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (21 forks)github user discovery
help wantedquestion

Repository metrics

Stars
 (80 stars)
PR merge metrics
 (PR metrics pending)

Description

Hi Mike,

Fist of all thanks for providing us such great libraries. Keep up the good work :)

In application that I am working on currently we are using your super cool solution MaterialDrawer with auto generated MiniDrawer. After some testing I noticed that content panel wasn't recreating as it should to.

Initial state for testing is opened Drawer and then change orientation. After recreation of activity content panel was shifted to the right even if withResizeContentPanel option was set on Crossfader builder.

Here you can look at demo code: link

Problem occurs on: Samsung S7 - android version 8.0, Android emulator Nexus 10 - android version 8.1, Android emulator Nexus 10 - android version 10.

Used latest Crossfader library version 1.6.0 Followed sample and instructions on MaterialDrawer

Sorry for bad English,

Cheers :)

Contributor guide

Research direction
Investigate the Crossfader's behavior on configuration changes, focusing on the content panel resizing logic and state restoration during activity recreation.
Tech stack
javaandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AndroidGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70