mikejihbe/metrics

Standard deviation is Nan

Open

#51 opened on Oct 3, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (58 forks)batch import
help wanted

Repository metrics

Stars
 (575 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

My service is outputting metrics to Grafana but it's end points are never called. What I'm finding is that the standard deviation value is NaN, output via:

send(util.format('%s.%s', histogram.name, 'stddev'), histogram.stdDev(), timestamp);

in graphite-reporter.js. I suspect this should output zero.

Contributor guide

Research direction
Examine the histogram's stdDev method to understand when it returns NaN. Then modify the method or the sending code to output 0 instead of NaN when there is insufficient data.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80