mikeerickson/validatorjs

:attribute showing field name instead of field label

Open

#232 opened on Jan 15, 2018

View on GitHub
 (2 comments) (0 reactions) (1 assignee)JavaScript (1,658 stars) (279 forks)batch import
bughelp wantednext

Description

Hi,

const editLocationFields = {
    fields: [
        'Calle',
        'NumExt',
        'NumInt',
        'Colonia',
        'Indicaciones',
        'Tipo',
        'lat',
        'lng'
    ],
    labels: {
        Tipo: 'Tipo de ubicación',
        NumExt: 'Número Exterior',
        NumInt: 'Número Interior',
        Indicaciones: 'Indicaciones'
    },
    rules: {
        Calle: 'required|string',
        NumExt: 'required_if:Tipo,Casa|string',
        Tipo: 'required|string'
    }
}

messages.js:48

_getAttributeName: function(attribute) {
    var name = attribute;
    if (this.attributeNames.hasOwnProperty(attribute)) {
      return this.attributeNames[attribute];
    } else if (this.messages.attributes.hasOwnProperty(attribute)) {
      name = this.messages.attributes[attribute];
    }
...

this.attributeNames only has NumExt fileld so when trying to find Tipo field, getAttributeName doesn't find anything and finally returns :attribute to key replacement (Tipo in this case). I suppose this.attributeNames must contains Tipo: "Tipo de ubicación" definition too.

Expected message: "Este campo es requerido cuando Tipo de ubicación es Casa" Current message: "Este campo es requerido cuando Tipo es Casa"

Is there something wrong with my fields definition?

Some help is much appreciated.

version: 3.14.2

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the ` getAttributeName` method in `messages.js` around line 48. The issue is that the `attributeNames` object does not contain all labels from the user's configuration. Check how `attributeNames` is built in the library's initialization or in the `setAttributeNames` method. Compare the expected behavior with the actual behavior and determine if the bug is in the method itself or in the way the labels are passed. Ensure that the fix accounts for all fields defined in the `labels` object.
:attribute showing field name instead of field label · mikeerickson/validatorjs#232 | Good First Issue