mike-north/ember-cli-materialize

[Bug] Parallax doesn't tear its self down completely

Open

#85 opened on Apr 24, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (305 stars) (117 forks)batch import
bugfixed in materialize-v1.0.0help wantedv0

Description

The following Materialize code registers various listeners, which should be torn down in the component's willDestroyElement hook

this.$('.parallax').parallax();

Potentially this will entail adding some "cleanup" methods to the Materialize project, which can then be called by this component

Contributor guide

Tech stack
javascriptcsshtml
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Ember.js component lifecycleKnowledge of jQuery event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
First, locate the Ember component file that initializes the parallax (likely in addon/components). Check if there is already a willDestroyElement hook and what cleanup is missing. Then, look at the Materialize parallax plugin source (typically in vendor or bower components) to see if it provides a destroy method. If not, the fix may involve adding a custom cleanup function that removes event listeners and the parallax instance. Review the single comment on the issue for any additional context.