mike-north/ember-cli-materialize

[Bug] Parallax doesn't tear its self down completely

Open

#85 opened on Apr 24, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (117 forks)batch import
bugfixed in materialize-v1.0.0help wantedv0

Repository metrics

Stars
 (305 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The following Materialize code registers various listeners, which should be torn down in the component's willDestroyElement hook

this.$('.parallax').parallax();

Potentially this will entail adding some "cleanup" methods to the Materialize project, which can then be called by this component

Contributor guide

Research direction
Inspect the component's willDestroyElement hook in the Ember component and ensure all listeners registered by the parallax plugin are properly cleaned up. Look at the Materialize parallax source to identify listeners that need teardown.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65