mike-north/ember-cli-materialize

[Bug] Navbar doesn't tear its self down completely

Open

#84 opened on Apr 24, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (305 stars) (117 forks)batch import
bugfixed in materialize-v1.0.0help wantedv0

Description

Calling the Materialize javascript

this.$('.button-collapse').sideNav({
  closeOnClick: true
});

Sets up some click listeners, which should be torn down in the component's willDestroyElement hook. Potentially this means enhancing the upstream Materialize project, or writing some ember-idiomatic code that does the same thing

Contributor guide

Tech stack
javascriptcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Ember.js component lifecycleMaterialize sideNav initialization
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the Ember component that initializes the sideNav. In the component's `willDestroyElement` hook, ensure that all click listeners set up by Materialize's sideNav are properly removed. This may require calling the destroy method of the sideNav instance or overriding Materialize's teardown. Review the Materialize source for a cleanup method.