miickel/gulp-angular-templatecache

Leading slash added to filenames under gulp 4

Open

#164 opened on Oct 28, 2018

View on GitHub
 (18 comments) (5 reactions) (0 assignees)JavaScript (533 stars) (97 forks)batch import
help wanted

Description

Calling this package with gulp 4 erroneously results in template filenames with leading separators.

This seems to be due to the breaking change in vinyl, where internal path records such as file.base are now normalized: https://github.com/gulpjs/vinyl/commit/9ae7cd10c5423cbad9d38fc6c99960c62ac2f429#diff-c49ce3c4dfcfa830e06789881dd4d5d4 That change breaks the following code: url = path.join(root, file.path.replace(base || file.base, ''));

It is the root cause of #153

I posted a workaround in the other issue, but I'll see if I can cook something up that's compatible with all vinyl versions instead

Contributor guide

Tech stack
javascriptnodejsangular
Domain
frontendbuild systemtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
gulpvinylNode.jsAngularJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the code around `url = path.join(root, file.path.replace(base || file.base, ''));` in the plugin's main file. Understand the change in vinyl's normalization of `file.base` (see https://github.com/gulpjs/vinyl/commit/9ae7cd10c5423cbad9d38fc6c99960c62ac2f429#diff c49ce3c4dfcfa830e06789881dd4d5d4). The fix should handle both normalized and non normalized paths. Consider using `file.relative` or checking if `file.path` already contains `root`. Also test with different versions of gulp and vinyl to avoid regressions.