miickel/gulp-angular-templatecache

Leading slash added to filenames under gulp 4

Open

#164 opened on Oct 28, 2018

View on GitHub
 (18 comments) (5 reactions) (0 assignees)JavaScript (97 forks)batch import
help wanted

Repository metrics

Stars
 (533 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Calling this package with gulp 4 erroneously results in template filenames with leading separators.

This seems to be due to the breaking change in vinyl, where internal path records such as file.base are now normalized: https://github.com/gulpjs/vinyl/commit/9ae7cd10c5423cbad9d38fc6c99960c62ac2f429#diff-c49ce3c4dfcfa830e06789881dd4d5d4 That change breaks the following code: url = path.join(root, file.path.replace(base || file.base, ''));

It is the root cause of #153

I posted a workaround in the other issue, but I'll see if I can cook something up that's compatible with all vinyl versions instead

Contributor guide

Research direction
Inspect the code around line `url = path.join(root, file.path.replace(base || file.base, ''))` and test with different vinyl versions to ensure compatibility.
Tech stack
javascriptnodejs
Domain
build systemtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.jsgulp
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60