miickel/gulp-angular-templatecache

Url passed to transformUrl should be normalized

Open

#115 opened on Jan 12, 2016

View on GitHub
 (11 comments) (0 reactions) (0 assignees)JavaScript (533 stars) (97 forks)batch import
help wanted

Description

On OS X, the url passed to the transformUrl function is normal, e.g. something like components/app/app.html. However, that same url on Windows becomes components//app//app.html.

It seems to be because somewhere along the line the Windows backslashes are converted to forward slashes, and for some reason an additional slash is added. This means you have to take into account when writing the transformUrl function, that the input you get is not going to be consistent across different OS's.

Is it possible to let the gulp-angular-templatecache normalize the url before passing it to the transformUrl function, so that there are no OS dependent differences?

Contributor guide

Tech stack
javascript
Domain
toolingbuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript basicsknowledge of Node.js path modulefamiliarity with gulp plugin development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the source code for the URL generation and transformation pipeline. Look at how the file path is converted to a forward slash URL. Implement normalization (e.g., using path.posix.normalize or replacing '//' with '/') before passing to transformUrl. Ensure consistency across Windows and Mac.