miguel-perez/smoothState.js

Ajax success method issue

Open

#229 opened on Nov 5, 2015

View on GitHub
 (4 comments) (1 reaction) (0 assignees)CSS (4,433 stars) (515 forks)batch import
bughelp wanted

Description

Hello,

My implementation has been choking on line 375 letting me know that $.ajax(settings).success(...) is not a function. After researching it seems that the success / error / complete callbacks can be defined in the settings object but there is no such function, the closest being done().

So I changed the source code to settings.success = function(...) and the same for error and complete, before calling $.ajax(settings).

It seems to be working. But not being a developper I'm not really sure that would be the appropriate fix...

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic jQueryJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate the issue in the smoothState.js repository. The user reports that line 375 in the main JavaScript file uses $.ajax(settings).success(), which is deprecated since jQuery 1.8. The suggested fix is to use .done() instead. However, confirm that the library still supports older jQuery versions and check if any other deprecated methods are used elsewhere. Also, verify that the current maintainer is active and whether a PR would be welcome.