miguel-perez/smoothState.js

onBefore hook not runs onpopstate and on load()

Open

#219 opened on Sep 28, 2015

View on GitHub
 (7 comments) (0 reactions) (0 assignees)CSS (4,433 stars) (515 forks)batch import
bughelp wanted

Description

onBefore hook not runs on "onpopstate" event (when user use "Back" button) and when load() method called. I think it should be in docs, or if it is bug, it should be fixed.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic understanding of smoothState.jsjQuery events
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Check the smoothState.js source code (likely smoothState.js or smoothstate.js) to verify if the onBefore hook is triggered on popstate events and when the load() method is called. Review the documentation at https://github.com/miguel perez/smoothState.js to see if this behavior is documented. Look for any comments in the issue thread for clarification. If the hook is not intended to run in these cases, it may be a documentation issue; otherwise, it's a bug that needs fixing.