miguel-perez/smoothState.js

Suggestion : enhance plugin with file upload support

Open

#217 opened on Sep 19, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)CSS (4,433 stars) (515 forks)batch import
enhancementhelp wanted

Description

For my project I added some lines to support file upload: . first check if 'FormData' is supported . if supported : use specific request definition (contentType has to be set to 'false') . if not supported : use original request definition (contentType can not be set to 'false')

if(typeof FormData === 'function'){
    // file upload supported
    var request = {
        url: $form.prop('action'),
        data: new FormData($form[0]),
        type: $form.prop('method'),
        async: false,
        cache: false,
        contentType: false,
        enctype: 'multipart/form-data',
        processData: false
    };
}else{
    // file upload not supported
    var request = {
        url: $form.prop('action'),
        data: $form.serialize(),
        type: $form.prop('method')
    };
}

If someone is aware of existing issues for this implementation, I would be glad to hear.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
jQueryFormData APIplugin architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the smoothState.js plugin's existing form submission handling, likely in the main JavaScript file. Check for any prior discussions or attempts to add file upload support. Consider browser compatibility for FormData and ensure the solution degrades gracefully. Since the issue is old, verify the repository is still active and whether the maintainer is accepting contributions.