miguel-perez/smoothState.js

height: auto on container

Open

#210 opened on Aug 19, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)CSS (4,433 stars) (515 forks)batch import
bughelp wantedunconfirmed

Description

Hi There,

Is there anyway to overwrite the height: auto on the main container. I'm using a fullscreen plugin that requires every parent to have a height of 100%;

I've tried adding a class that sets the height but it's inconsistent and flickery as hell on all browsers.

      onStart: {
          duration: 400,
          render: function (url, $container) {
            $('#main').addClass('move-out set-height');

            content.toggleAnimationClass('is-exiting');
            // Scroll user to the top
            $body.animate({
              scrollTop: 0
            });
          }
        },

  onEnd : {
          duration: 0,
          render: function (url, $container, $content) {
           $('#main').removeClass('move-out');
            $body.css('cursor', 'auto');
            $body.find('a').css('cursor', 'auto');
            $container.html($content);

issue

Is there anyway to overwrite this? thanks ^_^

Contributor guide

Tech stack
javascriptcss
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The user wants to override the 'height: auto' style applied to the main container. Look at smoothState.js source code for where this style is set (likely in the plugin's CSS or JavaScript). Consider adding an option to allow custom height, or provide documentation on how to override via CSS specificity. The issue is old and the repository may not be actively maintained, so a fork or workaround might be needed.