miguel-perez/smoothState.js

storePageIn() fails to find container in new doc if nested

Open

#193 opened on Jul 8, 2015

View on GitHub
 (8 comments) (0 reactions) (0 assignees)CSS (515 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,433 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Nesting the container even one level under the body tag prevents storePageIn() from find it.

<body>
    <div>
        <article id="js-smoothstate-content">
            <h1>TEST CONTENT</h1>
        </article>
    </div>
</body>

The filter() function won't find the container id (Chrome v43):

storePageIn: function (object, url, doc, id) {
    /../
    object[url] = { // Content is indexed by the url
        /../
        html: $newDoc.filter('#' + id), // Stores the contents of the page
    }; 
}

Consider using .find() instead?

Contributor guide

Research direction
Replace the filter() call with find() in the storePageIn function to allow nested containers.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptjQuery
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80