miguel-perez/smoothState.js

Add anchor tests

Open

#184 opened on Jun 13, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)CSS (4,433 stars) (515 forks)batch import
enhancementhelp wanted

Description

We should add the following tests:

  • ignores middle clicks
  • ignores command clicks
  • ignores ctrl clicks
  • ignores cross origin links
  • ignores [target] anchors
  • ignores same page anchors
  • ignores same page anchors from URL that has hash: 'window.location = "#foo"'
  • ignores event with prevented default

See tests/testAnchors.js.

Contributor guide

Tech stack
javascript
Domain
frontendtesting
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptfamiliarity with test files
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue lists specific test cases for anchor behavior. The tests should be added to the existing test file tests/testAnchors.js. Examine the existing test structure and patterns in that file, then implement each test case ensuring it correctly checks for ignored middle clicks, command clicks, etc. No additional context or dependencies are mentioned.