Logging to root logger
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Start with src/msgraph_core/requests/batch_request_builder.py around line 70 and src/msgraph_core/tasks/large_file_upload.py around line 133, then inspect how their loggers are created. Reproduce the bad batch request with logging.basicConfig(). Done means log messages from both modules go to module- or package-specific loggers rather than the root logger.
Written by the indexing model from the issue text.
Description
Describe the bug
The library logs to the root logger. As that's a widely-accepted bad practice, I guess it qualifies as a bug.
Expected behavior
All log messages should go to module- or package-specific loggers.
How to reproduce
import logging
logging.basicConfig()
# Send a bad batch request
SDK Version
1.3.8
Latest version known to work for scenario above?
No response
Known Workarounds
No response
Debug output
Configuration
No response
Other information
No response
- Dominant language
- Python
- Stars
- 288
- Forks
- 52
- Avg merge
- 8h 10m
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoftgraph/msgraph-sdk-python-core
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
status:waiting-for-triage type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
microsoftgraph/msgraph-sdk-python-core#1030 · 2 comments · 4 reactions ·
-
status:waiting-for-triage type:feature
Difficulty 3/5 1-2 days Newbie friendliness 52/100
-
status:waiting-for-triage type:bug
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
status:waiting-for-triage
Difficulty 5/5 Over a week Newbie friendliness 15/100
microsoftgraph/msgraph-sdk-python-core#935 · 1 reaction ·
All issues in microsoftgraph/msgraph-sdk-python-core
Similar issues
-
documentation help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
simonw/sqlite-utils#872 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100