The method documentation seems to be wrong because of copy paste?

Open
#1,755 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
documentation

Research direction

Start by inspecting src/GraphRequest.ts at lines 493-502, which the issue identifies as containing incorrect method documentation. Compare the wording with the method implementation and surrounding documentation, then correct the copied text and verify that the documentation matches the method. The Promise concern is broader and is not scoped to a specific change here.

Written by the indexing model from the issue text.

Description

It's quite obvious

https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/82bbf8f95e32e868fd448306df2219cac6622722/src/GraphRequest.ts#L493C2-L502C3

Also, I am very disappointed that the responses from the graph client are typed Promise. This is not a good coding style

Dominant language
TypeScript
Stars
833
Forks
240
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoftgraph/msgraph-sdk-javascript

All issues in microsoftgraph/msgraph-sdk-javascript

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.