Show which .exes in multi-.exe portable ZIPs that "Failed to parse the package from (…)" errors are about.

Open
#640 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
cli

Research direction

Search the codebase for the error text "Failed to parse the package from" and trace the path used when selecting installers from a ZIP archive. Update that path so each parse failure identifies the relevant .exe, then verify the resulting messages for multi-.exe portable ZIPs.

Written by the indexing model from the issue text.

Description

Issue-Feature
Description of the new feature / enhancement

Occasionally when I work on Winget-pgks packages that involve portable ZIPs with a lot of .exe-s in them (with https://github.com/microsoft/winget-pkgs/pull/326858 being the recentmost case), I logically attempt to try to see how many .exe-s I can get Wingetcreate to parse properly or not.

However, as indicated by the screenshot below, there's a fair bit of trial and error involved to try to eliminate which ones that can't be parsed:

Image

As such, additional clarifications in the error messages about which .exe-s that can't be passed, would've been splendid.

Proposed technical implementation details

For cases where Select the installer(s) from the zip archive:: are in use, change the Failed to parse the package from errors to either:

  • (example.exe:) Failed to parse the package from (…)
  • Failed to parse the package from(…)] (example.exe)`
Dominant language
C#
Stars
651
Forks
114
Avg merge
7h 52m
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/winget-create

All issues in microsoft/winget-create

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.