The number of new installer packages must match the number of existing installer packages

Open
#559 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
cli, tooling

Research direction

Start by reproducing the wingetcreate.exe update command from the issue with the two Cilium CLI release URLs, then compare the referenced installer manifests for versions 1.16.3 and 0.12.0. Trace where the installer-count error is reported. Done means the current two-package update can produce the updated manifest and submit its PR without that error.

Written by the indexing model from the issue text.

Description

Issue-Bug
Brief description of your issue

wingetcreate.exe fails to update manifest

Steps to reproduce

Run
wingetcreate.exe update Cilium.CiliumCLI -s -v 0.16.20 -u https://github.com/cilium/cilium-cli/releases/download/v0.16.20/cilium-windows-amd64.zip https://github.com/cilium/cilium-cli/releases/download/v0.16.20/cilium-windows-arm64.zip -t $($env:WINGET_PAT)

Expected behavior

Should have updated the manifest with new version and submitted the PR

Actual behavior

Failed to update manifest with error:

Retrieving latest manifest for Cilium.CiliumCLI
Downloading and parsing: https://github.com/cilium/cilium-cli/releases/download/v0.16.20/cilium-windows-amd64.zip...
Downloading and parsing: https://github.com/cilium/cilium-cli/releases/download/v0.16.20/cilium-windows-arm64.zip...
The number of new installer packages must match the number of existing installer packages.

Even though the number of packages is same as what is currently in https://github.com/microsoft/winget-pkgs/blob/master/manifests/c/Cilium/Hubble/1.16.3/Cilium.Hubble.installer.yaml

I believe this might be due to different number of installers in an older version: https://github.com/microsoft/winget-pkgs/blob/master/manifests/c/Cilium/Hubble/0.12.0/Cilium.Hubble.installer.yaml

Environment

Used in Github actions, winget-create is retreived using Invoke-WebRequest https://aka.ms/wingetcreate/latest -OutFile wingetcreate.exe

Dominant language
C#
Stars
651
Forks
114
Avg merge
7h 52m
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/winget-create

All issues in microsoft/winget-create

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.