Escape does not cancel a launch that uses command:SpecifyProgramArgs
@testforstephen is already working on this.
Since Feb 28, 2024.
Assessment
This issue has not been assessed yet.
Description
When launching a Java program with ${command:SpecifyProgramArgs}, the popup says that I can press 'Escape' to cancel, but it runs anyway.
Environment
- Operating System: Windows 11
- JDK version: 17.0.4.1
- Visual Studio Code version: 1.86.2
- Java extension version: 1.28.1
- Java Debugger extension version: 17.0.4.1
Steps To Reproduce
- Open the repo https://github.com/sbj42/vscode-specifyprogramargs
- Open
Test.javaand pressF5. - Pop-up appears with "Press 'Enter' to confirm your input or 'Escape' to cancel".
- Press Escape.
- Terminal appears and runs the test program with no arguments.
See repo above, but you only need these two files:
Test.java:
public class Test {
public static void main(String[] args) {
System.out.println("args: " + String.join(" ", args));
}
}
.vscode/launch.json:
{
"version": "0.2.0",
"configurations": [
{
"type": "java",
"name": "Launch with Arguments Prompt",
"request": "launch",
"mainClass": "",
"args": "${command:SpecifyProgramArgs}"
}
]
}
Verbose output log from "Language Support for Java": log.txt
Current Result
The debug session starts with no arguments.
Expected Result
The debug session should not start, because it was cancelled.
Additional Informations
The implementation of SpecifyProgramArgs is at extension.ts:185. When the user cancels, the function returns a string with a single space. That's indistinguishable from the user entering a space in the input.
I presume that throwing some sort of cancellation exception would be good here, for instance throw new Error('Launch cancelled'). It would be even better if the exception didn't display an error box, but I don't know enough about vscode extension command handlers to know if that's possible.
Alternatively you could just remove the "or 'Escape' to cancel" hint in the input popup.
- Dominant language
- TypeScript
- Stars
- 591
- Forks
- 429
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 19
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/vscode-java-debug
-
ai-triaged enhancement
Difficulty 3/5 1-2 days Newbie friendliness 55/100
microsoft/vscode-java-debug#1689 · 2 comments ·
-
ai-triaged bug
microsoft/vscode-java-debug#1666 · 1 comment · 1 assignee ·
-
ai-triaged bug
Difficulty 3/5 1-2 days Newbie friendliness 48/100
microsoft/vscode-java-debug#1658 · 1 comment ·
-
ai-triaged enhancement
Difficulty 4/5 3-5 days Newbie friendliness 45/100
microsoft/vscode-java-debug#1628 · 3 comments ·
-
Feature support. Openai-triaged enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
microsoft/vscode-java-debug#1616 · 1 comment ·
All issues in microsoft/vscode-java-debug
Similar issues
-
clawsweeper:linked-pr-open clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:message-loss issue-rating: 🦞 diamond lobster maturity:stable P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#616 ·
-
ZCode 3.14.3 に対応する Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
supermomonga/zcode-acp#24 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
growthbook/growthbook#7100 ·
-
triage
Difficulty 1/5 1-3 hours Newbie friendliness 88/100