No warning/error when opening invalid notebook file

Open
#166 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript, vscode
Domain
devtools

Research direction

Start by reproducing the issue in the VS Code notebook editor using a notebook whose raw JSON has a trailing comma. Trace the notebook opening path to determine where invalid JSON is handled; done means opening the file shows a warning or error instead of silently displaying an empty notebook.

Written by the indexing model from the issue text.

Description

Type: Bug

  1. Create a issue notebook
  2. Edit the raw json of the file an add a trailing , to make the json invalid
  3. Open the file again in the notebook editot

bug
The notebook is empty. No errors/warnings are shown

Extension version: 0.0.130
VS Code version: Code - Insiders 1.83.0-insider (Universal) (4268e464763087044d0c1b5bdd37ebbe683cadfa, 2023-09-29T20:44:15.716Z)
OS version: Darwin arm64 23.0.0
Modes:

System Info
Item Value
CPUs Apple M2 Max (12 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) 5, 4, 3
Memory (System) 64.00GB (0.50GB free)
Process Argv --crash-reporter-id 0fffb5da-9cd7-46fd-9e7f-a1564e8c5fda
Screen Reader no
VM 0%
Dominant language
TypeScript
Stars
237
Forks
37
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/vscode-github-issue-notebooks

All issues in microsoft/vscode-github-issue-notebooks

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.