To-client sequence numbers are misleadingly logged as 0
Nobody has claimed this yet.
Assessment
This issue has not been assessed yet.
Description
I noticed this when debugging vscode-go, which inherits from vscode-debugadapter and relies on much of the code in LoggingDebugSession, etc.
Here is a stack trace for logging the following response:
To client: {"seq":0,"type":"response","request_seq":2,"command":"launch","success":true}
- ProtocolServer::_send # sets
message.seq = this._sequence++before sending - ProtocolServer::sendResponse
- LoggingDebugSession::SendResponse # logs the message with
"seq":0before calling the above functions
Same thing happens with events.
This is quite unfortunate because logging is an important for implementers who want to studying the interactions between the client and the adapter.
Is there any downside to moving logging after the raw send when the response object is populated with the right seq number?
- Dominant language
- TypeScript
- Stars
- 306
- Forks
- 90
- Avg merge
- 8h 36m
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/vscode-debugadapter-node
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
microsoft/vscode-debugadapter-node#325 · 1 comment · 1 reaction ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
microsoft/vscode-debugadapter-node#307 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
All issues in microsoft/vscode-debugadapter-node
Similar issues
-
S: triage
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
fix(errors): EHOSTUNREACH from a happy-eyeballs connect is reported as a resolver error (STAMP-80) Open
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
snapshot-labs/stamp#666 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
GauravKarakoti/SecureFlow#1070 · 1 comment ·
-
feature:Languages/Translations good first issue ready Web
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
digitalfabrik/integreat-app#4394 ·