microsoft/vasim

Reading in CSVs with glob

Open

#18 opened on Aug 30, 2024

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Python (7 forks)auto 404
buggood first issuerefactor

Repository metrics

Stars
 (12 stars)
PR merge metrics
 (PR metrics pending)

Description

We are currently reading in all of the CSVs of the performance trace data using python's glob (list(self.data_dir.glob("**/*.csv"))) with no security checks. It seems like we need to do a bit more here in terms of sanitizing inputs.

Contributor guide

Research direction
Add input validation to restrict file paths to expected directories and patterns, e.g., by using a whitelist of allowed paths or sanitizing the glob pattern.
Tech stack
python
Domain
backendsecurity
Issue type
Security
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70