Override helpers

Open
#14 8 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
typescript
Domain
tooling

Research direction

Start by reviewing how tslib handles TypeScript 2.1's --importHelpers option and how the __extends helper is selected. Determine whether a supported override path can be defined; done means the regression is resolved or the recommended approach is clearly documented.

Written by the indexing model from the issue text.

Description

Introducing support for tslib in TS 2.1 is great as we can now easily use up-to-date TS helpers without maintaining our own copy of the source files from github. 😄

But it also introduced a regression: the option to override TS helpers with our own seems to have been lost?

Specifically, I want to provide my own __extends because the one provided by TS is (deliberately) buggy.
Before I could do that by having a global __extends that would take precedence. With the new --importHelpers it seems that I lost this option.

What is the recommended way to go about that?

Dominant language
TypeScript
Stars
1.3k
Forks
145
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/tslib

All issues in microsoft/tslib

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.