ab update: Trident tries to relabel shared partitions too when selinux is being used

Open
#565 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
rust

Research direction

Start by tracing the AB update path that generates the SELinux relabel list, then inspect how shared partitions and inactive volumes are selected. Use the setfiles and containerd paths described in the issue as the failure context. Done means active filesystems, including shared partitions, are not included in relabeling during an AB update.

Written by the indexing model from the issue text.

Description

bug

On AB update when SELinux is being used, Trident generates a list of all filesystems that must be relabeled. This list includes shared partitions, not only inactive volumes. This leads to a situation where we relabel active filesystems too. This generally doesn't case issues, but it may cause intermittent failures when incompatible processes are running and operating on the active OS.

An example of this is containerd, which manages many filesystem trees, overlays, and mounts in /var/lib/containerd. Past error reports have shown that setfiles may encounter issues and fail when it tries to relabel continerd-managed paths.

Dominant language
Rust
Stars
32
Forks
18
Avg merge
1d 17h
Merged PRs (30d)
31

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/trident

All issues in microsoft/trident

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.