TextEdit.applyEdits shouldn't use assert

Open
#161 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
php
Domain
tooling

Research direction

Locate TextEdit.applyEdits in the PHP sources and inspect the assertion for overlapping or out-of-order edits. The change is complete when invalid TextEdit[] input produces an exception instead of relying on an assertion.

Written by the indexing model from the issue text.

Description

I think the assert for "Supplied TextEdit[] must not overlap, and be in increasing start position order." should be an exception.

From #158

Dominant language
PHP
Stars
894
Forks
85
Avg merge
2d 13h
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/tolerant-php-parser

All issues in microsoft/tolerant-php-parser

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.