Focusable does not handle the inert attribute

Open
#369 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
accessibility

Research direction

Start by locating the Focusable implementation and the isAccessible check mentioned in the issue. Reproduce the failure with an inert element and with an element nested inside an inert ancestor, then verify that focusable elements in both cases are excluded without breaking other focus behavior.

Written by the indexing model from the issue text.

Description

Tabster breaks on elements with inert, or nested within an ancestor with inert.

The easiest solution might be to add :not([inert]):not([inert] *) to the focusable selector, or add an explicit check (maybe in isAccessible?)

Dominant language
TypeScript
Stars
165
Forks
42
Avg merge
1d 11h
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/tabster

All issues in microsoft/tabster

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.