Shadow DOM: implement `Node.contains()` function to support shadow roots and slots

Open
#337 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
accessibility, frontend

Research direction

Start with the linked implementation in shadow-dom/src/pierce-dom/elementContains/index.ts and inspect how Tabster currently handles Node.contains(), shadow roots, and slots. Validate the behavior with the relevant existing tests, then determine the appropriate integration point and confirm that containment works across the stated cases.

Written by the indexing model from the issue text.

Description

Node.contains() does not handle shadow roots. Implement an "elementContains()" function to handle shadow roots.

This is implemented

We need to validate the implementation and decide how to best include it in Tabster.

Dominant language
TypeScript
Stars
165
Forks
42
Avg merge
1d 11h
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/tabster

All issues in microsoft/tabster

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.