[Bug] Deloser throws error when a form has an input with name `id`

Open
#227 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
accessibility

Research direction

Start at src/Deloser.ts line 299 and reproduce the false positive using the linked CodeSandbox. Check how a form control named id affects the existing element.id check. Done means forms containing an input named id no longer trigger the erroneous Deloser error, while the intended check still works.

Written by the indexing model from the issue text.

Description

bug

https://github.com/microsoft/tabster/blob/master/src/Deloser.ts#L299

This check has a false positive for forms with an input named id since element.id will point to the input element in the form.

Sandbox for reproduction: https://codesandbox.io/s/agitated-khorana-hzqyu2?file=/src/index.tsx

Dominant language
TypeScript
Stars
165
Forks
42
Avg merge
1d 11h
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/tabster

All issues in microsoft/tabster

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.