Commit b062f2c breaks many projects

Open
#1,149 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
sql
Domain
build-system, databases

Research direction

Start by inspecting commit b062f2c and the truncated file at samples/databases/wide-world-importers/wwi-ssdt/wwi-ssdt/PostDeploymentScripts/pds150-ins-app-cities-h.sql. Compare the affected files with their pre-commit versions and identify which projects no longer build; done means restoring the broken content without discarding later changes and verifying the affected samples build.

Written by the indexing model from the issue text.

Description

The commit b062f2c, is according to commit message only "remove extra spacing", but really contains several changes where half a file is completely deleted, making many of the projects not being able to build.

Here is an example of a broken file by this commit. The file ends abruptly.

I can make that exact project build simply by reverting commit b062f2c, but I do not feel comfortable doing this to the entire repo. Other projects have received more recent commits, and simply reverting b062f2c leads to new stuff that needs to be fixed.

Dominant language
PowerShell
Stars
11.2k
Forks
9.1k
Avg merge
2d 7h
Merged PRs (30d)
14

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/sql-server-samples

All issues in microsoft/sql-server-samples

Similar issues

More Build System issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.