Java: API - What about importing skills/plugins from the root directory in the classpath?

Open
#128 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
java
Domain
api

Research direction

Start by locating SkillExecutor and the existing importSkillFromResources(String pluginDirectory, String skillName, String functionName) method. Check how an empty pluginDirectory resolves a root-classpath skill, then verify that the requested overload supports the two-argument call while preserving the existing method behavior.

Written by the indexing model from the issue text.

Description

java

Today, to import a skill from the classpath we use the following SkillExecutor method:

ReadOnlyFunctionCollection importSkillFromResources(
            String pluginDirectory, String skillName, String functionName);

But when the skill is at the root of the classpath, we need to invoke the method passing a blank to the pluginDirectory parameter:

kernel.importSkillFromResources("", "NarrationSkill", "NarrateFight");

It would be good to have another method that does not have a pluginDirectory parameter and looks straight from the root:

kernel.importSkillFromResources("NarrationSkill", "NarrateFight");

WDYT ?

Dominant language
Java
Stars
276
Forks
56
Avg merge
17h 45m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/semantic-kernel-java

All issues in microsoft/semantic-kernel-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.