microsoft/perfview

Freeze processing in EventPipeEventSource if uncaught exception is thrown in callback.

Open

#1,290 opened on Oct 15, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (687 forks)batch import
bughelp wanted

Repository metrics

Stars
 (3,819 stars)
PR merge metrics
 (Avg merge 1h 51m) (2 merged PRs in 30d)

Description

Environment

  • Microsoft.Diagnostics.Tracing.TraceEvent: 2.0.61
  • Microsoft.Diagnostics.NETCore.Client: 0.2.141901
  • EventPipe sender app and receiver app's TFM: net5.0-rc2

Steps to reproduce

  1. run app which produce EventSource event periodically
  2. start EventPipe session by DiagnosticClient
  3. create EventPipeEventSource from event stream
  4. set callback to DynamicEventParser.All
    • Exception will be thrown in callback
  5. start processing

full test code is uploaded to gist

Expected result

callback is invoked periodicaly, or at least terminate event processing when EventPipeEventSource.StopProcessing is called.

Actual result

callback was never invoked again, and EventPipeEventSource.Process never returned, even if EventPipeEventSource.StopProcessing was called.

Contributor guide

Research direction
Trace the code path in EventPipeEventSource.Process() and check for unhandled exceptions in the callback. Look for any error handling mechanisms that may prevent the processing loop from continuing.
Tech stack
csharp
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#.NET Core
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50