“SIGINT - custom in parent and child” is flaky on Linux (possibly need slow CPU to reproduce)
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- electron, node.js, typescript
- Domain
- operating-systems, testing-qa
Research direction
Start with lib/unixTerminal.test.js around line 171 and the failing “SIGINT - custom in parent and child” test. Run the UnixTerminal signal tests on Linux, including a slower or non-x86_64 environment if available, and compare the parent and child signal behavior. Done means the test is reliable while still verifying custom SIGINT handling in both processes.
Written by the indexing model from the issue text.
Description
Environment details
- OS: Linux (various Fedora and openSUSE)
- node-pty version: 1.1.0-beta21 (as shipped in vscode)
- node.js version: Electron 30.x with ELECTRON_RUN_AS_NODE
Issue description
18 passing (13s)
1 failing
1) UnixTerminal
signals in parent and child
SIGINT - custom in parent and child:
Uncaught AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
false !== true
+ expected - actual
-false
+true
at ChildProcess.<anonymous> (lib/unixTerminal.test.js:171:28)
at ChildProcess.emit (node:events:519:28)
at maybeClose (node:internal/child_process:1105:16)
at ChildProcess._handle.onexit (node:internal/child_process:305:5)
We've observed this test occasionally failing on aarch64, arm and riscv64, but never on x86_64. (This is possibly due to our x86_64 machines being fast)
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 337
- Avg merge
- 21h 58m
- Merged PRs (30d)
- 3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/node-pty
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
All issues in microsoft/node-pty
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
bug v2
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
modelcontextprotocol/inspector#2458 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
railmapgen/rmp-gallery#4068 ·
-
Mend: dependency security vulnerability status: needs triage 🕵️♀️
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
carbon-design-system/ibm-products#9907 ·