encoding null returns Buffer on linux but string on windows!
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- node.js, typescript
- Domain
- cli, operating-systems
Research direction
Reproduce the shown pty.spawn example with encoding:null using bash -i and cmd.exe, then inspect the mypty.on('data') entry point and how each platform delivers its payload. Done means the encoding:null behavior is consistent across both platforms, with the expected Buffer type verified on Linux and Windows.
Written by the indexing model from the issue text.
Description
if (typeof process.env.ComSpec == "undefined") {
cmd = "bash";
cmdargs = ["-i"]
} else {
cmd = "cmd.exe";
cmdargs = []
}
mypty = pty.spawn( cmd, cmdargs, {
name: 'xterm-256color',
cols: 80,
rows: 25,
env: process.env,
encoding: null
});
if cmd and cmdargs is bash -i, with encoding:null mypty.on("data") returns a Buffer as it should.
but if running on windows and cmd and cmdargs are CMD.EXE then mypty.on("data") returns a STRING!
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 337
- Avg merge
- 21h 58m
- Merged PRs (30d)
- 3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/node-pty
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
All issues in microsoft/node-pty
Similar issues
-
VerificationGate: ATTRIBUTION quote guard never matches a normal quotation (\b around the quote) Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
danielmiessler/LifeOS#2234 ·
-
T: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
Mend: dependency security vulnerability untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 70/100