provide a way to control argv[0] of the spawned process
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- node.js, typescript
- Domain
- api, operating-systems
Research direction
The public entry point is node-pty's spawn API; start by tracing how its arguments become the execv argv shown in the issue. Define the argv[0] behavior and verify the requested value is passed through without breaking the existing spawn form, using the project's process-spawn tests.
Written by the indexing model from the issue text.
Description
To properly fix https://github.com/microsoft/vscode/issues/123332 node-pty must provide a way to control argv[0] of the spawned process, that is, instead of…
const ptyProcess = (await import('node-pty')).spawn("/bin/sh", ["--login"], options);
… which internally does an…
execv("/bin/sh", "/bin/sh", "--login", NULL);
… vscode must do something like…
const ptyProcess = (await import('node-pty')).spawna("/bin/sh", "-sh", [], options);
// or
const ptyProcess = (await import('node-pty')).spawna("/bin/sh", ["-sh"], options);
… which internally does an…
execv("/bin/sh", "-sh", NULL);
… so a new API will be needed, unless this can be put into options somehow, perhaps…
const ptyProcess = (await import('node-pty')).spawna("/bin/sh", [], {"argv0": "-sh"});
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 337
- Avg merge
- 21h 58m
- Merged PRs (30d)
- 3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/node-pty
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
All issues in microsoft/node-pty
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ontola/atomic-server#1625 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
melgarafael/DeskcommCRM#1451 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
bug via-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bot:ai-assisted component:compact-js status:untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
midnightntwrk/midnight-sdk#403 ·