breaking change missing 3.0.0: findNodeAtLocation() can return undefined; parseTree() can return undefined in more cases
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- compilers
Research direction
The issue names parseTree() and findNodeAtLocation() but no file or test. Start by locating their TypeScript declarations and the 3.0.0 API or changelog entry; confirm the documented undefined cases, then update the relevant documentation and any existing coverage for these entry points.
Written by the indexing model from the issue text.
Description
Breaking change in 3.0.0 is not just "fixed API spec for parseTree. Can return undefine for empty input.".
But also findNodeAtLocation() type is fixed: it can return undefined.
"Can return undefine for empty input" is incomplete. It will return undefined in those cases and probably even more, too:
'' empty string
' ' blank
' ' tab
'// test' comment only
'/* test */' comment only
'+'
'-'
'}'
'} {}'
']'
':'
','
"'foo'"
"abc"
- Dominant language
- TypeScript
- Stars
- 759
- Forks
- 66
- Avg merge
- 5d 10h
- Merged PRs (30d)
- 7
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/node-jsonc-parser
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
microsoft/node-jsonc-parser#125 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
microsoft/node-jsonc-parser#103 · 2 comments · 8 reactions ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
microsoft/node-jsonc-parser#97 · 2 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
microsoft/node-jsonc-parser#95 · 1 reaction ·
-
Difficulty 1/5 Under an hour Newbie friendliness 35/100
All issues in microsoft/node-jsonc-parser
Similar issues
-
blocklist removal
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
MetaMask/eth-phishing-detect#296544 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
pastelsky/bundlephobia#1122 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
category/development priority/P2 scope/file-operations scope/testing type/enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Enatega Customer and Rider app: Add-ons price is not visible to customer after order is placed. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100