microsoft/nni

No error raise for wrong type of result

Open

#3,641 opened on May 14, 2021

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Python (13,504 stars) (1,830 forks)batch import
help wanteduser raised

Description

Describe the issue:

When parsing value in torch.tensor with dtype=torch.float to nni.report_intermediate_result and nni.report_final_result, there is no Exception raised and no result recorded.

It is desired to raise a ValueError, or auto-convert to python float (raise a ValueError when cannot be converted).

Environment:

  • NNI version:
  • Training service (local|remote|pai|aml|etc):
  • Client OS:
  • Server OS (for remote mode only):
  • Python version:
  • PyTorch/TensorFlow version:
  • Is conda/virtualenv/venv used?:
  • Is running in Docker?:

Configuration:

  • Experiment config (remember to remove secrets!):
  • Search space:

Log message:

  • nnimanager.log:
  • dispatcher.log:
  • nnictl stdout and stderr:

How to reproduce it?:

Contributor guide

Tech stack
pythonpytorch
Domain
machine learning
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonPyTorchNNI API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the implementation of report intermediate result and report final result in the NNI source code (likely in nni/report.py or similar). Add a type check for the result parameter; if it is a torch.Tensor, attempt to convert to a Python float or raise ValueError. Follow existing error handling conventions in the codebase. No pull requests are linked; the issue has an assignee but no recent activity.
No error raise for wrong type of result · microsoft/nni#3641 | Good First Issue