microsoft/microsoft-ui-xaml

Icon on MenuFlyoutItem within a dark container turns black on pointer exit (with OS in light mode theme color)

Open

#5,381 opened on Jul 7, 2021

View on GitHub
 (10 comments) (0 reactions) (0 assignees)C# (5,815 stars) (659 forks)batch import
area-Menusbughelp wantedreact-native-windowsteam-Controls

Description

Steps to reproduce the bug

  1. Clone or download https://github.com/lyahdav/CppWinRtUwpSandbox
  2. Run solution https://github.com/lyahdav/CppWinRtUwpSandbox/blob/main/cppwinrt/Calendar.sln
  3. Click MenuFlyout button
  4. Hover over the 2nd menu item and then hover away from it

Expected behavior Icon for the menu item stays white. Instead it changes to black.

Screenshots

https://user-images.githubusercontent.com/359157/124684321-b002fd00-de83-11eb-91cb-c3d780cf5215.mov

Version Info Windows 10 21H1 / 19043.928 Islands

Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context The relevant code is here: https://github.com/lyahdav/CppWinRtUwpSandbox/blob/main/SharedContent/cppwinrt/MainPage.cpp#L65-L91. I have two workarounds there as well:

  1. Reload the icon on PointerExited. This isn't ideal since it flickers.
  2. Explicitly set BitmapIcon.Foreground(nullptr).

Contributor guide

Tech stack
csharp
Domain
frontenddesktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of WinUIFamiliarity with XAML stylingUnderstanding of pointer eventsWindows 10 development setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the default style for MenuFlyoutItem and BitmapIcon in the WinUI repository. The issue likely involves a missing or incorrect theme resource binding for the icon foreground when the pointer exits. Check the generic.xaml file for relevant templates. Also review the comments for any additional context or potential fixes that were discussed.