microsoft/microsoft-ui-xaml

Control Styles should be named

Open

#3,735 opened on Dec 1, 2020

View on GitHub
 (16 comments) (1 reaction) (0 assignees)C# (5,815 stars) (659 forks)batch import
area-Stylinghelp wantedteam-Controlswct

Description

While investigating this, I noticed an issue for this that is a complete show stopper: there is no way to override the default TabViewItem style. Unlike some other controls, the TabViewItem does not follow the pattern of:

<Style TargetType="ControlName" BasedOn="DefaultControlNameStyle"/>

<Style x:Key="DefaultControlNameStyle" TargetType="ControlName">
...
</Style>

but rather just exposes the complete template as the default style leaving users with no choice of easily overriding the default style. However that is something that we would need for this feature to be easily usable. @ranjeshj @stmoy @StephenLPeters Is that something we can change to make that customization easier?

@michael-hawker FYI

Originally posted by @chingucoding in https://github.com/microsoft/microsoft-ui-xaml/issues/2587#issuecomment-732463534

Contributor guide

Tech stack
csharp
Domain
desktopfrontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
XAML stylingWinUI controlsC# basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the current default style pattern for TabViewItem and other controls in the repository. Identify where default styles are defined (likely in generic.xaml). Propose a change to follow the 'DefaultControlNameStyle' pattern as used by other controls, ensuring backward compatibility. Consult maintainers @ranjeshj, @stmoy, @StephenLPets for guidelines on naming conventions.