microsoft/microsoft-ui-xaml

[ColorPicker] R/G/B or H/S/V fields should not accept alphabetical characters - move to NumberBox?

Open

#3,420 opened on Oct 13, 2020

View on GitHub
 (9 comments) (1 reaction) (0 assignees)C# (659 forks)batch import
accessibilityarea-ColorPickerhelp wantedteam-Controls

Repository metrics

Stars
 (5,815 stars)
PR merge metrics
 (Avg merge 5d 15h) (9 merged PRs in 30d)

Description

Describe the bug The input fields in the ColorPicker control should only accept numerical values, not alphabetical values. When entering an alphabetical value and tabbing to the next inputfield will remove the incorrect character.

This is fine. However, Windows Narrator will still announce the alphabetical character and will not let the (visually impaired) user know that the value was incorrect.

We are running into this issue with PowerToys Settings: https://github.com/microsoft/PowerToys/issues/7085

Steps to reproduce the bug

  1. Turn on Narrator
  2. Navigate (with tab) to the Red field.
  3. Enter character (e.g. 'a')
  4. Narrator says A
  5. Tab to the next field.

Expected behavior Since these are numberfields, why not use the NumberBox control? This would be more approriate (we can set the min and max as well!) and improves accesbility.

Screenshots image

Contributor guide

Research direction
Identify the input fields in the ColorPicker control that accept text and replace them with NumberBox controls, ensuring proper min/max values and accessibility. Investigate the current validation logic and update it to use NumberBox's built in validation.
Tech stack
csharp
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#XAML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70