microsoft/microsoft-ui-xaml

[ColorPicker] R/G/B or H/S/V fields should not accept alphabetical characters - move to NumberBox?

Open

#3,420 opened on Oct 13, 2020

View on GitHub
 (9 comments) (1 reaction) (0 assignees)C# (5,815 stars) (659 forks)batch import
accessibilityarea-ColorPickerhelp wantedteam-Controls

Description

Describe the bug The input fields in the ColorPicker control should only accept numerical values, not alphabetical values. When entering an alphabetical value and tabbing to the next inputfield will remove the incorrect character.

This is fine. However, Windows Narrator will still announce the alphabetical character and will not let the (visually impaired) user know that the value was incorrect.

We are running into this issue with PowerToys Settings: https://github.com/microsoft/PowerToys/issues/7085

Steps to reproduce the bug

  1. Turn on Narrator
  2. Navigate (with tab) to the Red field.
  3. Enter character (e.g. 'a')
  4. Narrator says A
  5. Tab to the next field.

Expected behavior Since these are numberfields, why not use the NumberBox control? This would be more approriate (we can set the min and max as well!) and improves accesbility.

Screenshots image

Contributor guide

Tech stack
csharp
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine the ColorPicker control source files (likely in /Microsoft.UI.Xaml/src/controls/ColorPicker) to find the RGB/HSV input fields. Replace the current TextBox with NumberBox control, setting Min and Max values appropriately. Ensure the change maintains existing functionality and improves Narrator announcements. Refer to the linked PowerToys issue #7085 for additional context on the accessibility problem.
[ColorPicker] R/G/B or H/S/V fields should not accept alphabetical characters - move to NumberBox? · microsoft/microsoft-ui-xaml#3420 | Good First Issue