microsoft/microsoft-ui-xaml

Proposal: TabViewItem should respect CornerRadius API

Open

#3,084 opened on Aug 9, 2020

View on GitHub
 (7 comments) (4 reactions) (0 assignees)C# (659 forks)batch import
area-TabViewfeature proposalhelp wantedteam-Controls

Repository metrics

Stars
 (5,815 stars)
PR merge metrics
 (Avg merge 5d 15h) (9 merged PRs in 30d)

Description

Proposal: TabViewItem should respect CornerRadius API

Summary

To set the corner radius of a TabViewItem, developers today have to override the OverlayCornerRadius resource. They should also be able to use the TabViewItem.CornerRadius API for that.

Example

<muxc:TabView>
    <muxc:TabView.TabItems>
        <muxc:TabViewItem Header="Tab 1" CornerRadius="0">
            Some tab content
        </muxc:TabViewItem>
    </muxc:TabView.TabItems>
</muxc:TabView>

image

Additional Context

This proposal is related to a few other TabViewItem issues like https://github.com/microsoft/microsoft-ui-xaml/issues/3047 and https://github.com/microsoft/microsoft-ui-xaml/issues/2653. @stmoy FYI

Contributor guide

Research direction
Study how TabViewItem's CornerRadius is currently applied via the OverlayCornerRadius resource in the default style, then modify the control to support the CornerRadius property by updating the style template and adding a dependency property.
Tech stack
csharp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65